[Dcmlib] strange behaviour

[Jean-Pierre Roux]

Lazzarato Dr.Gianni wrote:
>
> Hi Mathieu, hi JP,
>
> I apologize because I’m continuosly boring you. J
>

HIiGianni.
Don't aplogize!
We greatly apppreciate that you report the bugs you find.
And that you give us tracks for fixing them.

I hope this one will fixed very soon.
JP


> I think I have find the bug and it seem general and quite severe 
> (because change the number of slices)
>
> In the file gdcmseriehelper.cxx :
>
> *line 781* if (DropDuplicatePositions)
>
> {
>
> //todo ImagePositionPatientOrdering wrong duplicates are found ???
>
> it3 = distmultimap.upper_bound((*it3).first); // skip all duplicates
>
> if (it3 == distmultimap.end() ) // if last image, stop iterate
>
> break;
>
> }
>
> *line 798* if (DropDuplicatePositions) // skip all duplicates
>
> {
>
> it4 = distmultimap.upper_bound((*it4).first);
>
> if (it4 == distmultimap.begin() ) // if first image, stop iterate
>
> break;
>
> }
>
> There are found duplicates else if none are present. ( I test it 
> checking slice by slice some datasets where, for sure, not duplicates 
> are present).
>
> This cause the bad behaviour I found .
>
> Right now, I commented out these 2 blocks of code and my datasets are 
> well loaded.
>
> Any suggestions?
>
> Tnx for your attention.
>
> Gianni
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Dcmlib mailing list
> Dcmlib at creatis.insa-lyon.fr
> http://www.creatis.insa-lyon.fr/mailman/listinfo/dcmlib