[Fwd: [Dcmlib] new RM]

[Luca Picello]

In attachment my modifications to port new sort algorithm to current gdcm.
I have no datasets to check the difference. Hope it's ok.

my 2 eurocents,
Luca


Mathieu Malaterre wrote:

> Actually to be perfectly honest the version you are using can still be 
> broken, a patch was applied yesterday to ITK-gdcm:
>
> http://www.itk.org/cgi-bin/viewcvs.cgi/Utilities/gdcm/src/gdcmSerieHelper.cxx.diff?cvsroot=Insight&r1=1.2&r2=1.3 
>
>
> BUG: The bucket sort algorithm to sort a series by distance was 
> flawed. The algorithm reported duplicate positions when in fact there 
> were gaps existing in the dicom series. The new algortihm uses a 
> multimap. It still checks for duplicate positions, but will do a 
> correct sort if there are not duplications. Also, the old code used 
> the gdcmDebugMacro to report the duplicate positions. This code uses 
> gdcmErrorMacro so that users will be modified of the duplicate 
> positions. Eventually, gdcm will have better mechanisms to support 
> error handling.
>
>
> A similar patch should be merged back to 1.0.x branch and CVS.
>
> Mathieu... really too busy to follow gdcm dvpt
>
> Luca Picello wrote:
>
>> Errata!!!!
>>
>> the new RMs are read perfectly!!!
>> it was my fault: I selected the wrong directory :-)
>>
>> the only (still) problem that is missing is on orientation.
>> however... thank you developers for your fantastic work!!! :-)
>>
>> Luca
>>
>>
>>
>>
>> -------- Original Message --------
>> Subject:     [Dcmlib] new RM
>> Date:     Fri, 23 Sep 2005 21:45:40 +0200
>> From:     Luca Picello <luca.picello at libero.it>
>> To:     dcmlib at creatis.insa-lyon.fr <dcmlib at creatis.insa-lyon.fr>
>>
>>
>>
>> Hello folks,
>> I've got new RM datasets I'd like to read with gdcm but it seems we 
>> have something similar to the old order issue.
>> I can forward the entire dataset or if you need some information to 
>> debug I can check them as my proof of good will :-)
>>
>> Are there any news on typeOrientation ?
>> I downloaded the todays's cvs and I continue to have Orientation = 0 
>> (not allowed!), as described in my last email.
>>
>> please let me know,
>>
>> thank you all,
>> Luca
>>
>> _______________________________________________
>> Dcmlib mailing list
>> Dcmlib at creatis.insa-lyon.fr
>> http://www.creatis.insa-lyon.fr/mailman/listinfo/dcmlib
>> .
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Dcmlib mailing list
>> Dcmlib at creatis.insa-lyon.fr
>> http://www.creatis.insa-lyon.fr/mailman/listinfo/dcmlib
>
>
> .
>

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gdcmSerieHelper.cxx
URL: <http://www.creatis.insa-lyon.fr/pipermail/dcmlib/attachments/20050929/81751be3/attachment.cxx>