[Dcmlib] Checkin the 'Value Multiplicity'

[Mathieu Malaterre]

Jean-Pierre Roux wrote:
> Mathieu Malaterre wrote:
> 
>> Jean-Pierre Roux wrote:
>>
>>>   Hi, Mathieu, Benoit.
>>>
>>> Something you probabely forgot, is the entry 'Type' :
>>
>>
>> Nope, see the comment I put in gdcm::DataEntry::IsValueCountValid.
>> This is definitely on my TODO list. We should not pretend being able 
>> to write DICOM file without support for this. Otherwise we'll have to 
>> support yet another broken DICOM file format: the one produce by gdcm. 
>> So as long as we are not able to check that, I would say that the file 
>> we write are invalid (which seems to be the case, since dciodvy also 
>> complains about gdcm file).
> 
> 
> I do agree with you.
> We *must* write kosher dicom files.
> I think the good way is to check *our* files at write time (or when a 
> user -us?- sets a value).

That's where it becomes complex with the current dictionary. Try 
creating a LUTData (28,3006). It can be VR=US, VM=1-n *or* VR=OW, VM=1
Right now we only support the second one. And supporting the first one 
will be tricky.

> I probabely wrote something stupid in the 'mandatory' entries default 
> writing.
> I tried to install dicom3tools, to check the files we write;
> But 'imake' hangs ... (I probabely forgot to modify something somewhere 
> ...)

Don't know what you did, but I generally do:
$ make
-> complains and give me the proper commands to run:

$ ./Configure
$ imake -I./config
$ make World

Still hanging ?
I tried once to get D. Clunie to move to sf.net to have cvs access and 
then I would be able to write him cmakelists files.

> Why don't everybody use CMake :-( ?

hehe ;-)

> We shouldn't be happy whith gdcm wtiter till there is not a single 
> warning running dciodvy.

Cool someone on my side :)

Mathieu
Ps: I tried the newest release:

  $ history 

     1  cd /tmp
     2  wget 
http://www.dclunie.com/dicom3tools/workinprogress/dicom3tools_1.00.snapshot.20051010.helgray.tar.bz2
     3  tar xvfj dicom3tools_1.00.snapshot.20051010.helgray.tar.bz2
     4  cd dicom3tools_1.00.snapshot.20051010.helgray
     5  make
     6  ./Configure
     7  imake -I./config
     8  make World