[Dcmlib] GDCM in VTK using BCB

[Mathieu Malaterre]

Luca,

  Sorry but I am not convinced this is the perfect patch(*)... could you please send me the file:

CMakeError.log and CMakeOutput.log

I would like to study them to understand what went wrong during the compilation.

Thanks a bunch,
Mathieu
(*) If you include windows.h in a header file you are basically telling the compiler to process 900000 lines of ugly macro for every single cxx file you compile. This is a HUGE slowdown of compilation and you completely pollute the namespace with unneeded typedef/#define ...


> Good news:
> now it compiles!!!
> Just adding
> 
> #ifdef __BORLANDC__
>   #include <stdint.h>
>   #include <ctype.h>
>   #include <stdlib.h>
>   #include <windows.h>
> #endif
> 
> Bye,
> Luca
> 
> 
> 
> Luca Picello wrote:
> 
> >
> > Hello Mathieu,
> > thanks for quick answer!! I downloaded latest CVS
> > [ cvs -d:pserver:anonymous at cvs.creatis.insa-lyon.fr:2402/cvs/public co 
> > gdcm. ]
> >
> > and after 1.0 version
> > [ cvs -d:pserver:anonymous at cvs.creatis.insa-lyon.fr:2402/cvs/public co 
> > -r Version1_0 gdcm. ]
> >
> > In both I met the same problem.
> >
> > Changes needed to love BCB (Borland C++ Builder 6, not free compiler) 
> > are in gdcmCommon.h I made:
> >
> > // Broken plateform do not respect C99 and do not provide those typedef
> > #if defined(_MSC_VER)
> > typedef  signed char         int8_t;
> > typedef  signed short        int16_t;
> > typedef  signed int          int32_t;
> > typedef  unsigned char       uint8_t;
> > typedef  unsigned short      uint16_t;
> > typedef  unsigned int        uint32_t;
> > #define UINT32_MAX    (4294967295U)
> > #endif
> >
> > #ifdef __BORLANDC__
> >   #include <stdint.h>
> >   #include <ctype.h>
> >   #include <stdlib.h>
> > #endif
> >
> >
> > but if I made it wrong please tell me.
> > Thanks,
> >
> > Luca
> >
> >
> >
> >
> >
> > Mathieu Malaterre wrote:
> >
> >>Luca,
> >>
> >>  Could you include the version of gdcm you are using ? gdcm is being compiled AND run nightly with bcc32. As far as I know there is not a single line of code you need to change. Please use the latest gdcm 1.0 version.
> >>
> >>Thanks
> >>Mathieu
> >>Ps: look for a file called winbase.h the GetTickcount is defined here.
> >>
> >>
> >>  
> >>
> >>>*I would like to use Dcmlib in VTK, using Borland C++ Builder compiler.*
> >>>
> >>>*I adjusted some header files but I cannot make it run because:*
> >>>
> >>>*Z:\gdcm\src\gdcmUtil.cxx:*
> >>>
> >>>*Error E2316 Z:\gdcm\src\gdcmUtil.cxx 284: 'Util::GetTickCount()' is not 
> >>>a member of 'Util'*
> >>>
> >>>**** 1 errors in Compile ****
> >>>
> >>>*Searching for GetTickCount() in all directories I can't find it so I 
> >>>believe it is Windows GetTickCount() API function... or not?
> >>>
> >>>*
> >>>
> >>>*thanks for any help in advance,*
> >>>
> >>>*Picello Luca*
> >>>
> >>>*
> >>>*
> >>>
> >>>
> >>>    
> >>>
> >>>------------------------------------------------------------------------
> >>>
> >>>_______________________________________________
> >>>Dcmlib mailing list
> >>>Dcmlib at creatis.insa-lyon.fr
> >>>http://www.creatis.insa-lyon.fr/mailman/listinfo/dcmlib
> >>>    
> >>>
> >
> >------------------------------------------------------------------------
> >
> >_______________________________________________
> >Dcmlib mailing list
> >Dcmlib at creatis.insa-lyon.fr
> >http://www.creatis.insa-lyon.fr/mailman/listinfo/dcmlib
> >
> 
> 
>