[Dcmlib] Solution (?) around GetVersion()

[Jean-Pierre Roux]

Jean-Pierre Roux wrote:

> Mathieu Malaterre wrote:


Mathieu,
Would you have any objection if I move GetVersion() from gdcmCommon.h to 
gdcmUtil.h ?
User will have to use it as
gdcm::Util::GetVersion()
instead of
gdcm::GetVersion().
It seems not to cause trouble elsewhere.
JP

>
>> Jean-Pierre Roux wrote:
>>
>>> Hi!
>>> The adjunction of gdcm:GetVersion()  causes some troubles on 
>>> 'Gogolt' (at least)
>>
>>
>>
>> Yeah I fix a compilation problem gcc4 for some reason don't like ; 
>> laying around.
>> And it does not like a static function not used within the shared lib. 
>
>
> It complains for *each* cxx module, not only at the shared lib level...
>
>> I think to easily solve the problem I will puit the value in the gdcm 
>> image we are writting.
>
>
> I'm affraid I didn't get it ...
> -> I'm interested in using gdcm:GetVersion() in the 
> FileHelper::CheckMandatoryElements() method, and replace the stupid line
> e_0002_0013->SetValue("GDCM 1.1");
> by
> e_0002_0013->SetValue(GetVersion());
> when I write a Dicom File.
>
> What do you want to do?
> JP
>
>>
>> Is everybody ok ? I will put is in software version or one tags like 
>> that.
>>
>> Mathieu
>> _______________________________________________
>> Dcmlib mailing list
>> Dcmlib at creatis.insa-lyon.fr
>> http://www.creatis.insa-lyon.fr/mailman/listinfo/dcmlib
>>
> _______________________________________________
> Dcmlib mailing list
> Dcmlib at creatis.insa-lyon.fr
> http://www.creatis.insa-lyon.fr/mailman/listinfo/dcmlib
>