excellent ! ok for me ...<br><br>however, another potential issue : I cannot read anymore a 4D image, it crashes ... only for me ? any idea ? <br><br>log : <br>ERROR: In /home/dsarrut/src/vtk/vtk-5.4.2/Filtering/vtkDemandDrivenPipeline.cxx, line 828<br>
vtkStreamingDemandDrivenPipeline (0x1ed2c70): Input for connection index 0 on input port index 1 for algorithm vtkImageReslice(0x1d990c0) is of type vtkImageData, but a vtkImageStencilData is required. <br><br>David<br><br>
<div class="gmail_quote">On Tue, Apr 27, 2010 at 20:17, Simon Rit <span dir="ltr"><<a href="mailto:simon.rit@gmail.com">simon.rit@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I added a coding style section on the wiki:<br>
<a href="http://www.creatis.insa-lyon.fr/rio/internalSoftware#Coding_style" target="_blank">http://www.creatis.insa-lyon.fr/rio/internalSoftware#Coding_style</a>.<br>
Please review it and when we agree, we can do it... (before the<br>
release would be good).<br>
<div><div></div><div class="h5"><br>
On Tue, Apr 27, 2010 at 10:42 AM, Joël Schaerer <<a href="mailto:joel.schaerer@gmail.com">joel.schaerer@gmail.com</a>> wrote:<br>
> RTFM :)<br>
><br>
> jschaerer@cepe:~/workspace/cvs/clitk3> astyle --help<br>
><br>
> Artistic Style 1.23<br>
> Maintained by: Jim Pattee<br>
> Original Author: Tal Davidson<br>
><br>
> Usage : astyle [options] Source1.cpp Source2.cpp [...]<br>
> astyle [options] < Original > Beautified<br>
><br>
> When indenting a specific file, the resulting indented file RETAINS the<br>
> original file-name. The original pre-indented file is renamed, with a<br>
> suffix of ".orig" added to the original filename.<br>
><br>
> Wildcards (* and ?) may be used in the filename.<br>
> A 'recursive' option can process directories recursively.<br>
><br>
> By default, astyle is set up to indent C/C++/C#/Java files, with 4 spaces<br>
> per indent, a maximal indentation of 40 spaces inside continuous statements,<br>
> and NO formatting.<br>
><br>
> Option's Format:<br>
> ----------------<br>
> Long options (starting with '--') must be written one at a time.<br>
> Short options (starting with '-') may be appended together.<br>
> Thus, -bps4 is the same as -b -p -s4.<br>
><br>
> Predefined Style Options:<br>
> -------------------------<br>
> --style=allman OR --style=bsd OR -A1<br>
> Allman style formatting/indenting.<br>
> Broken brackets.<br>
><br>
> --style=java OR -A2<br>
> Java style formatting/indenting.<br>
> Attached brackets.<br>
><br>
><br>
> On 04/27/2010 10:38 AM, Simon Rit wrote:<br>
>> What is astyle?<br>
>><br>
>> On Tue, Apr 27, 2010 at 10:37 AM, Joël Schaerer <<a href="mailto:joel.schaerer@gmail.com">joel.schaerer@gmail.com</a>> wrote:<br>
>><br>
>>> On 04/27/2010 10:32 AM, David Sarrut wrote:<br>
>>><br>
>>> astyle ? ok can we do what has been proposed at once ?<br>
>>><br>
>>> Yes, if everyone agrees. Note that astyle cannot do any of these:<br>
>>><br>
>>><br>
>>><br>
>>>>> - all member functions start with an upper case (like vtk and itk, but<br>
>>>>> unlike QT !) : SetToto(a) and GetToto()<br>
>>>>><br>
>>> - all member variables start with m, eg : mToto or mTiti (unlike vtk, unlike<br>
>>> qt, unlike itk)<br>
>>> - delimitate the function (in cxx and txx) with comment like //------------<br>
>>> (see for example clitkBinarizeImageGenericFilter.txx)<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> On Tue, Apr 27, 2010 at 10:30, Joël Schaerer <<a href="mailto:joel.schaerer@gmail.com">joel.schaerer@gmail.com</a>><br>
>>> wrote:<br>
>>><br>
>>>> I don't really have a preference, but I suggest that we change all the<br>
>>>> sources at once with astyle once we converge on a standard. Of course<br>
>>>> using the default astyle layout would be the simplest :)<br>
>>>><br>
>>>> On a completely unrelated topic, if you use vv a lot from the command<br>
>>>> line, I suggest adding the following line to your .bashrc:<br>
>>>><br>
>>>> complete -A file -X '*.raw' vv<br>
>>>><br>
>>>> It makes dealing with mhd files a lot more pleasant.<br>
>>>><br>
>>>> joel<br>
>>>><br>
>>>> On 04/27/2010 09:36 AM, Simon Rit wrote:<br>
>>>><br>
>>>>> After working a bit on clitk3, I have the feeling that there is<br>
>>>>> absolutely no consistency between (and even within) files. I don't<br>
>>>>> really think we should adopt a coding standard because we should keep<br>
>>>>> our own coding styles but it would be nice if we could just set a<br>
>>>>> minimal set of rules for the sake of readability. I suggest these ones<br>
>>>>> first:<br>
>>>>> - indentation: 2 spaces<br>
>>>>> - tabs are replaced by spaces<br>
>>>>> - opening and closing characters of a block are aligned vertically, e.g.<br>
>>>>> if (true)<br>
>>>>> {<br>
>>>>> }<br>
>>>>> - types are suffixed with Type (as in ITK if I'm not mistaking)<br>
>>>>> - preprocessor defines and macros in upper case<br>
>>>>><br>
>>>>> For the rest (e.g. naming of functions and variables), we can try to<br>
>>>>> follow the rules of our third-party libraries (itk and vtk). What do<br>
>>>>> you think?<br>
>>>>> Simon<br>
>>>>> _______________________________________________<br>
>>>>> vv mailing list<br>
>>>>> <a href="mailto:vv@creatis.insa-lyon.fr">vv@creatis.insa-lyon.fr</a><br>
>>>>> <a href="http://www.creatis.insa-lyon.fr/mailman/listinfo/vv" target="_blank">http://www.creatis.insa-lyon.fr/mailman/listinfo/vv</a><br>
>>>>><br>
>>>>><br>
>>>><br>
>>>> --<br>
>>>> Joël Schaerer, PhD<br>
>>>> Research Engineer<br>
>>>><br>
>>>> Centre de lutte contre le cancer Léon Bérard<br>
>>>> Service de radiothérapie<br>
>>>> 28 rue Laënnec<br>
>>>> 69373 LYON CEDEX 08<br>
>>>><br>
>>>> Tel: 04 78 78 51 50<br>
>>>> 06 26 65 29 54<br>
>>>><br>
>>>> <a href="http://www.creatis.insa-lyon.fr/rio" target="_blank">http://www.creatis.insa-lyon.fr/rio</a><br>
>>>> <a href="http://www.creatis.insa-lyon.fr/rio/vv" target="_blank">http://www.creatis.insa-lyon.fr/rio/vv</a><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> vv mailing list<br>
>>>> <a href="mailto:vv@creatis.insa-lyon.fr">vv@creatis.insa-lyon.fr</a><br>
>>>> <a href="http://www.creatis.insa-lyon.fr/mailman/listinfo/vv" target="_blank">http://www.creatis.insa-lyon.fr/mailman/listinfo/vv</a><br>
>>>><br>
>>><br>
>>><br>
>>> --<br>
>>> David Sarrut, Phd<br>
>>> Chargé de recherche CNRS<br>
>>> Centre de lutte contre le cancer Léon Bérard<br>
>>> 28 rue Laënnec, 69373 Lyon cedex 08<br>
>>> Laboratoire CREATIS-LRMN UMR CNRS 5220, Inserm U 630<br>
>>> Tel : 04 78 78 51 51 / 06 74 72 05 42<br>
>>> <a href="http://www.creatis.insa-lyon.fr/rio" target="_blank">http://www.creatis.insa-lyon.fr/rio</a><br>
>>> ______________________________________________<br>
>>> "2 + 2 = 5, for extremely large values of 2"<br>
>>> ______________________________________________<br>
>>><br>
>>> _______________________________________________<br>
>>> vv mailing list<br>
>>> <a href="mailto:vv@creatis.insa-lyon.fr">vv@creatis.insa-lyon.fr</a><br>
>>> <a href="http://www.creatis.insa-lyon.fr/mailman/listinfo/vv" target="_blank">http://www.creatis.insa-lyon.fr/mailman/listinfo/vv</a><br>
>>><br>
>>><br>
>>> --<br>
>>> Joël Schaerer, PhD<br>
>>> Research Engineer<br>
>>><br>
>>> Centre de lutte contre le cancer Léon Bérard<br>
>>> Service de radiothérapie<br>
>>> 28 rue Laënnec<br>
>>> 69373 LYON CEDEX 08<br>
>>><br>
>>> Tel: 04 78 78 51 50<br>
>>> 06 26 65 29 54<br>
>>><br>
>>> <a href="http://www.creatis.insa-lyon.fr/rio" target="_blank">http://www.creatis.insa-lyon.fr/rio</a><br>
>>> <a href="http://www.creatis.insa-lyon.fr/rio/vv" target="_blank">http://www.creatis.insa-lyon.fr/rio/vv</a><br>
>>><br>
>>> _______________________________________________<br>
>>> vv mailing list<br>
>>> <a href="mailto:vv@creatis.insa-lyon.fr">vv@creatis.insa-lyon.fr</a><br>
>>> <a href="http://www.creatis.insa-lyon.fr/mailman/listinfo/vv" target="_blank">http://www.creatis.insa-lyon.fr/mailman/listinfo/vv</a><br>
>>><br>
>>><br>
>>><br>
>> _______________________________________________<br>
>> vv mailing list<br>
>> <a href="mailto:vv@creatis.insa-lyon.fr">vv@creatis.insa-lyon.fr</a><br>
>> <a href="http://www.creatis.insa-lyon.fr/mailman/listinfo/vv" target="_blank">http://www.creatis.insa-lyon.fr/mailman/listinfo/vv</a><br>
>><br>
><br>
><br>
> --<br>
> Joël Schaerer, PhD<br>
> Research Engineer<br>
><br>
> Centre de lutte contre le cancer Léon Bérard<br>
> Service de radiothérapie<br>
> 28 rue Laënnec<br>
> 69373 LYON CEDEX 08<br>
><br>
> Tel: 04 78 78 51 50<br>
> 06 26 65 29 54<br>
><br>
> <a href="http://www.creatis.insa-lyon.fr/rio" target="_blank">http://www.creatis.insa-lyon.fr/rio</a><br>
> <a href="http://www.creatis.insa-lyon.fr/rio/vv" target="_blank">http://www.creatis.insa-lyon.fr/rio/vv</a><br>
><br>
> _______________________________________________<br>
> vv mailing list<br>
> <a href="mailto:vv@creatis.insa-lyon.fr">vv@creatis.insa-lyon.fr</a><br>
> <a href="http://www.creatis.insa-lyon.fr/mailman/listinfo/vv" target="_blank">http://www.creatis.insa-lyon.fr/mailman/listinfo/vv</a><br>
><br>
_______________________________________________<br>
vv mailing list<br>
<a href="mailto:vv@creatis.insa-lyon.fr">vv@creatis.insa-lyon.fr</a><br>
<a href="http://www.creatis.insa-lyon.fr/mailman/listinfo/vv" target="_blank">http://www.creatis.insa-lyon.fr/mailman/listinfo/vv</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>David Sarrut, Phd<br>Chargé de recherche CNRS<br>Centre de lutte contre le cancer Léon Bérard<br>28 rue Laënnec, 69373 Lyon cedex 08<br>Laboratoire CREATIS-LRMN UMR CNRS 5220, Inserm U 630<br>
Tel : 04 78 78 51 51 / 06 74 72 05 42<br><a href="http://www.creatis.insa-lyon.fr/rio">http://www.creatis.insa-lyon.fr/rio</a><br>______________________________________________<br> "2 + 2 = 5, for extremely large values of 2"<br>
______________________________________________<br>